Fix handling of null transducer models (#218) #219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
added @sadhana-r for visibility and but you don't have to review unless you want to |
7 tasks
arhowe00
requested changes
Feb 26, 2025
Contributor
arhowe00
left a comment
arhowe00
left a comment
There was a problem hiding this comment.
I tested this on main and this branch with the M2 transducer, and everything seems to work. A few discussion points.
Part of the work for #218 Co-authored-by: Andrew Howe <arhowe00@gmail.com>
ebrahimebrahim
commented
Feb 26, 2025
- Make intent more clear by parametrizing with `Optional[str]` and initializing paths within the test.
Contributor
|
My type checker doesn't give any complaints about the one above, and we don't need to use empty path |
arhowe00
approved these changes
Feb 27, 2025
Contributor
arhowe00
left a comment
arhowe00
left a comment
There was a problem hiding this comment.
Ready to merge unless @ebrahimebrahim you would like to revert the changes I made to the testing function or add more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #218
Added a test that fails before and passes after this fix