Skip to content

Conversation

@ebrahimebrahim
Copy link
Collaborator

@ebrahimebrahim ebrahimebrahim commented Nov 12, 2024

Close #156

This was needed for OpenwaterHealth/SlicerOpenLIFU#132 where the serialization/deserialization of SolutionAnalysis had to work perfectly

I didn't add a unit test since we aren't testing Solution.analyze just yet

@ebrahimebrahim ebrahimebrahim changed the title Convert value to float in Solution.analyze (#156) Convert value to float in Solution.analyze Nov 12, 2024
Copy link
Contributor

@ltetrel ltetrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ebrahimebrahim ebrahimebrahim merged commit 6876410 into main Nov 12, 2024
9 checks passed
@ebrahimebrahim ebrahimebrahim deleted the fix_float_type_bug branch March 12, 2025 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

solution analysis values are not float but rather np.float

3 participants