Change Solution.focus to a list of foci #127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebrahimebrahim
force-pushed
the
issue_125
branch
from
8f86a40 to
46696a8
Compare
Collaborator
Author
|
The changes so far should work with |
Collaborator
Author
|
@ltetrel we can merge your #104 work before this if you want, and then I will rebase this. I just added you for an initial review just so you get a chance to anticipate the upcoming changes while you work on your current thing. Feel free to put off review till after #104 is done, whatever you prefer. |
Contributor
|
I don't remember if we want to have a list of targets as well (for example for a wheel pattern). |
Contributor
Okay I remember now, we can have multiple focus "that will resolve" into a single target |
Collaborator
Author
Correct |
ltetrel
approved these changes
Oct 23, 2024
This includes * changing Solution.focus to Solution.foci and making that be a *list* of Points rather than a Point. * changing the xarray simulation data to have an additional coord "focal_point_index" * adding an axis to the delay and apodization arrays in Solution to index focal points. no need for instance checking anymore since foci will always be a list solution output analysis now takes into account foci list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #125
This includes
Remaining to do:
db-extended-example-v05.zip)