test_first notebook throws "unexpected keyword argument 'grid_weights'"

[ebrahimebrahim]

The test_first notebook contains this error for me:

TypeError: kWaveArray.get_distributed_source_signal() got an unexpected keyword argument 'grid_weights'

in reference to this line:

OpenLIFU-python/pyfus/sim/kwave_if.py

Line 64 in 46d73e8

source.p = karray.get_distributed_source_signal(kgrid, source_sig, grid_weights=grid_weights)

[peterhollender]

Didn't get the backwards-compatibility to the unpatched k-wave-python correct. Closed by 81f8941. The use of cached gridweights is being discussed at waltsims/k-wave-python#342, so this may need to get updated in the future if we can come up with an official solution to the performance bottleneck my modifications were working on.

[ebrahimebrahim]

@peterhollender TY for the fix! Two large PRs are coming shortly for #5 -- let's avoid pushing to directly to main from now on 😅

[ebrahimebrahim]

@peterhollender Would you be willing to retract the commit 81f8941 from the main branch and make a separate PR that only updates the notebooks to fix this error? The alternative would be for me to rebase #16 and #17 onto the new main branch, but there are a few reasons I think it might be better to retract the commit and use #16 and #17 instead:

• the commits in Reorganize to prep for applying scientific-python cookie #16 are more separated based on what they do
• the commits in Reorganize to prep for applying scientific-python cookie #16 reference the issue they are associated with

This is better for requirements traceability. Let me know what you think and if you want me to rebase the PRs I can still do that with some effort

[peterhollender]

Sure, I'll retract it.

[peterhollender]

Also, the fix for that bug is actually a change in pyfus/sim/kwave_if.py, which is going to move, so I'll fix it in src/openlifu/sim/kwave_if.py after we merge #16?

[ebrahimebrahim]

I see, yes that should work, thank you!!

development will get easier once we are done with sweeping reorganizations like this 🙂