fix(api): specify v_offset in transfer touch_tip #4602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When transfers emit a touch_tip in v1, they just pass the keyword arg value as the first positional parameter. It is, however, a number, and interpreted as a voffset by touch_tip; but it also emits a warning, which you can see if you're simulating. Just pass it as the v_offset keyword arg. No behavior change other than the warning going away is expected here. Closes #3703
Laura-Danielle
approved these changes
Dec 13, 2019
sfoster1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When transfers emit a touch_tip in v1, they just pass the keyword arg value as
the first positional parameter. It is, however, a number, and interpreted as a
voffset by touch_tip; but it also emits a warning, which you can see if you're
simulating. Just pass it as the v_offset keyword arg.
No behavior change other than the warning going away is expected here.
Closes #3703
overview
changelog
review requests