Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(python): configure setuptools to use legacy editable installs #11341

Merged
merged 3 commits into from
Aug 12, 2022

Conversation

mcous
Copy link
Contributor

@mcous mcous commented Aug 12, 2022

Overview

This PR fixes mypy failures that started happening locally and in CI this week by implementing a workaround suggested in python/mypy#13392.

Changelog

  • build(python): configure setuptools to use legacy editable installs

Review requests

Please note that after this PR, CI will not be green due to continued conflict resolution errors from #11320. I will be opening a separate PR for those fixes for history cleanliness

  • API lint CI passes fails for legitimate reasons
  • Robot Server lint CI passes fails for legitimate reasons
  • Running make setup && make lint works locally in api and robot-server

Risk assessment

I think low, but sort of hard to say...

@mcous mcous requested a review from a team as a code owner August 12, 2022 18:33
Copy link
Contributor

@SyntaxColoring SyntaxColoring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me if CI passes. Thanks!

@codecov
Copy link

codecov bot commented Aug 12, 2022

Codecov Report

Merging #11341 (589c87b) into edge (c5aec79) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #11341      +/-   ##
==========================================
+ Coverage   74.57%   74.63%   +0.05%     
==========================================
  Files        2047     2047              
  Lines       56800    56892      +92     
  Branches     5526     5526              
==========================================
+ Hits        42361    42463     +102     
+ Misses      13198    13188      -10     
  Partials     1241     1241              
Flag Coverage Δ
app 74.71% <ø> (ø)
components 53.32% <ø> (ø)
g-code-testing 97.13% <ø> (+<0.01%) ⬆️
hardware 59.95% <ø> (+1.09%) ⬆️
labware-library 49.74% <ø> (ø)
notify-server 89.17% <ø> (ø)
protocol-designer 45.81% <ø> (ø)
react-api-client 82.98% <ø> (ø)
shared-data 86.08% <ø> (+0.06%) ⬆️
step-generation 88.39% <ø> (ø)
update-server 73.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ware/opentrons_hardware/hardware_control/motion.py 80.59% <0.00%> (-3.53%) ⬇️
hardware/opentrons_hardware/sensors/sensor_abc.py 78.12% <0.00%> (-1.19%) ⬇️
...ons_hardware/hardware_control/move_group_runner.py 80.11% <0.00%> (-0.13%) ⬇️
shared-data/js/constants.ts 100.00% <0.00%> (ø)
hardware/opentrons_hardware/scripts/move.py 0.00% <0.00%> (ø)
hardware/opentrons_hardware/scripts/gripper.py 0.00% <0.00%> (ø)
hardware/opentrons_hardware/scripts/sensors.py 0.00% <0.00%> (ø)
hardware/opentrons_hardware/scripts/sensor_pass.py 0.00% <0.00%> (ø)
...ardware/opentrons_hardware/scripts/sensor_utils.py 0.00% <0.00%> (ø)
...ware/opentrons_hardware/scripts/monitor_sensors.py 0.00% <0.00%> (ø)
... and 24 more

@mcous mcous marked this pull request as draft August 12, 2022 18:47
@mcous mcous marked this pull request as ready for review August 12, 2022 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants