-
Notifications
You must be signed in to change notification settings - Fork 55
feat: update SafeErc20 to newer Solidity version #652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
simon0x1800
wants to merge
17
commits into
OpenZeppelin:main
Choose a base branch
from
simon0x1800:feature/620-update-safe-erc20
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: update SafeErc20 to newer Solidity version #652
simon0x1800
wants to merge
17
commits into
OpenZeppelin:main
from
simon0x1800:feature/620-update-safe-erc20
+417
−111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…zero-reset strategy
…in ISafeErc20 trait
…xed method for clarity and consistency in ISafeErc20 trait
…contract implementation
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
…mon0x1800/OpenZeppelin-rust-contracts-stylus into feature/620-update-safe-erc20
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
…g with calldata for improved error handling and clarity
…mon0x1800/OpenZeppelin-rust-contracts-stylus into feature/620-update-safe-erc20
…proved clarity and consistency
✅ Deploy Preview for contracts-stylus canceled.
|
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the SafeERC20 implementation to match the latest Solidity version, adding support for new features and improving error handling. The changes include:
try_safe_transfer
andtry_safe_transfer_from
functions that return bool instead of revertingforce_approve
function for handling tokens requiring zero-reset approvaltransfer_and_call_relaxed
,transfer_from_and_call_relaxed
, andapprove_and_call_relaxed
functionssafe_increase_allowance
andsafe_decrease_allowance
functionsResolves #620
PR Checklist