-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Audit]: N-03 Inconsistent Error Types #336
Labels
effort: low
Easy or tiny task that takes less than a day.
priority: 2
We will resolve this in a short timeframe.
type: ref
A code update that doesn't meaningfully change functionality.
Milestone
Comments
bidzyyys
added
priority: 2
We will resolve this in a short timeframe.
effort: low
Easy or tiny task that takes less than a day.
type: ref
A code update that doesn't meaningfully change functionality.
labels
Oct 14, 2024
The solution is to have the trait and associated error type to enable implementers to define custom errors throughout. It may not be the cleanest approach but seems like the most flexible. |
bidzyyys
added a commit
that referenced
this issue
Oct 15, 2024
bidzyyys
added a commit
that referenced
this issue
Oct 15, 2024
bidzyyys
added a commit
that referenced
this issue
Oct 15, 2024
bidzyyys
added a commit
that referenced
this issue
Oct 15, 2024
bidzyyys
added a commit
that referenced
this issue
Oct 15, 2024
bidzyyys
added a commit
that referenced
this issue
Oct 15, 2024
This was referenced Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
effort: low
Easy or tiny task that takes less than a day.
priority: 2
We will resolve this in a short timeframe.
type: ref
A code update that doesn't meaningfully change functionality.
What is the feature you would like to see?
Throughout the codebase, there are some extensions that use associated error types to allow
users the flexibility to assign a generic Vec as an error type and encode any error that is
needed (or not return an error at all), while others do not use this error style. For example, in
the IERC20 trait of the ERC20 implementation.
Consider using a consistent error style to avoid confusion and improve code clarity.
Contribution Guidelines
The text was updated successfully, but these errors were encountered: