Skip to content
This repository was archived by the owner on Nov 15, 2021. It is now read-only.

Comments

Add a port number as an optional config value#127

Open
chebykin wants to merge 1 commit intoOpenZeppelin:masterfrom
chebykin:add-port-option
Open

Add a port number as an optional config value#127
chebykin wants to merge 1 commit intoOpenZeppelin:masterfrom
chebykin:add-port-option

Conversation

@chebykin
Copy link

This will solve #65 if you specify the same port number in eth-gas-reporter and test-environment configs. When you ignore a port number value in your config, it will use a default undefined just like before.

@frangio
Copy link
Contributor

frangio commented Jul 17, 2020

Thanks for the suggestion @chebykin! This is an interesting way to achieve support for gas reporting. As a side effect, though, degining a port number will make parallel tests (with Jest or AVA) stop working. So I'm not sure the solution is acceptable for us.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants