This repository was archived by the owner on Nov 15, 2021. It is now read-only.
Add a port number as an optional config value#127
Open
chebykin wants to merge 1 commit intoOpenZeppelin:masterfrom
Open
Add a port number as an optional config value#127chebykin wants to merge 1 commit intoOpenZeppelin:masterfrom
chebykin wants to merge 1 commit intoOpenZeppelin:masterfrom
Conversation
Contributor
|
Thanks for the suggestion @chebykin! This is an interesting way to achieve support for gas reporting. As a side effect, though, degining a port number will make parallel tests (with Jest or AVA) stop working. So I'm not sure the solution is acceptable for us. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will solve #65 if you specify the same port number in
eth-gas-reporterandtest-environmentconfigs. When you ignore a port number value in your config, it will use a defaultundefinedjust like before.