CappedToken mint modifiers removed #969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nice! and good catch on RBACMintableToken + Capped. Do you think it would be valuable to have a |
|
and thanks for the mild test refactor, too 👍 |
|
Sure thing. I did need to extract some behaviours to keep the tests clean and not duplicate them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Description
I removed onlyOwner and canMint modifiers in CappedToken since those are used in the super.mint method and onlyOwner was blocking minting when CappedToken was used together with RBACMintableToken.
I also updated the unit tests for CappedToken to test for MintableToken behaviour.
npm run lint:all:fix).