Fix Node 10 compatibility #949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@frangio It would be nice to have the travis tests run on the current node version and on the LTS. What do you think about adding node 10 to the travis matrix? |
|
I don't think it's crucial at this moment because the JS code we have is not the core of the library, we're only using it to test the Solidity code. (This is somewhat of a lie because the JS tests and helpers are included in the npm package.) If at some point we have JavaScript code that is actually part of the library (and I think we need to go in this direction soon), then we should explore enhancing the Travis matrix to ensure compatibility, etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some native packages are not compiling due to deprecated APIs. This PR updates those.