-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ownable: add a notice on renounceOwnership #937
ownable: add a notice on renounceOwnership #937
Conversation
Maybe replace this line:
With this one:
To make things more clear |
Thanks for the comment @k06a. That is not related to this PR though. Why don't you make the change and propose it in a separate PR, so we can discuss in there? |
b299695
to
cc4586a
Compare
contracts/ownership/Ownable.sol
Outdated
@@ -42,6 +42,9 @@ contract Ownable { | |||
|
|||
/** | |||
* @dev Allows the current owner to relinquish control of the contract. | |||
* @notice Renouncing to ownership will leave the contract without an owner. | |||
* It will not be possible to call anymore the functions with the onlyOwner |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick: the english would flow better like:
"It will not be possible to call the functions with the onlyOwner modifier anymore."
Updated. Thanks for the review @shrugs ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to take extra measures to make renounceOwnership
hard to call?
We can do something like add an argument to it that the user must explicitly pass. Perhaps the address of the contract itself.
I like that idea @frangio, like on github where you have to confirm that you want to delete a repo by entering the repo name. Report an issue to explore it further? |
Opened #1000. |
π Description
I added a notice to warn users calling renounceOwnership.
npm run lint:all:fix
).