Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing misleading comment #925

Closed
wants to merge 1 commit into from

Conversation

redsquirrel
Copy link
Contributor

@redsquirrel redsquirrel commented May 3, 2018

This contract is not multiowned, nor owned at all.

Fixes #

πŸš€ Description

  • πŸ“˜ I've reviewed the OpenZeppelin Contributor Guidelines
  • βœ… I've added tests where applicable to test my new functionality.
  • πŸ“– I've made sure that my contracts are well-documented.
  • 🎨 I've run the JS/Solidity linters and fixed any issues (npm run lint:all:fix).

This contract is not multiowned, nor owned at all.
@frangio
Copy link
Contributor

frangio commented May 3, 2018

Thanks @redsquirrel! Actually DayLimit is left over from back when we had a multisig wallet in OpenZeppelin. The contract now isn't useful at all, we should just remove it.

@come-maiz
Copy link
Contributor

@redsquirrel would you mind updating your PR to remove the contract instead, as suggested by @frangio ?

shrugs added a commit to shrugs/openzeppelin-solidity that referenced this pull request May 30, 2018
@shrugs shrugs mentioned this pull request May 30, 2018
4 tasks
@shrugs shrugs closed this in #964 Jun 1, 2018
shrugs added a commit that referenced this pull request Jun 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants