Skip to content

Conversation

@NimrodHunter
Copy link

Fixes #

🚀 Description

In ethereum/EIPs#721 the official draft of ERC721 token, in the approve function, when the _to address is equal to 0 and have a previous state, the function have to clear the state and trigger the approve event.

  • 📘 I've reviewed the OpenZeppelin Contributor Guidelines
  • [] ✅ I've added tests where applicable to test my new functionality.
  • 📖 I've made sure that my contracts are well-documented.
  • 🎨 I've run the JS/Solidity linters and fixed any issues (npm run lint:all:fix).

@spalladino
Copy link
Contributor

Thanks for the catch, @NimrodHunter! I added this check in #803, with a test case here. I'm closing this issue in favour of that PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants