-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solium Integration, Linting Refactor #673
Conversation
8495794
to
38d7bfc
Compare
I fixed each set of lint errors iteratively in separate commits; to do a review, please check each commit separately (so you can make sure that that commit exclusively contains whitespace changes, for example). |
A key note is that 0 logic has been changed (if it has, let me know!!) so this should have 0 external effect to things that depend on zeppelin-solidity. |
Checked line by line, only aesthetic changes. |
Solium Integration, Linting Refactor
npm run lint:fix
) and fixed all issues.Fixes #656
Closes #556
π Description
I cherry picked @azavalla's first commit to make sure that contribution is counted. Added npm script and travis integration as well as a secondary refactor commits.
I marked things like
arg-overflow
,security/no-inline-assembly
,security/no-low-level-calls
, andsecurity/no-block-members
as warnings. Note that warnings don't fail the travis scriptFor each rule still producing a warning:
Some issues we can't fix for backwards-compatibility reasons (namely,
uppercase
for public variables in ERC20), so I've added the ignore directives (but those are, ironically, being ignored, probably because it's a beta feature).