Remove duplicated constructor call in FinalizableCrowdsaleImpl #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you give context for this? |
|
Yes! See here. |
|
Thanks @federicobond. 🙂 I wouldn't see this as duplicated super constructor calls. I find it somewhat weird because of the Solidity inconsistency between zero-arity constructors, which are implicitly called, and non-zero-arity constructors, which aren't. Regardless, I'm all for removing the redundant constructor call in this case. Can you rebase before merging? |
federicobond
force-pushed
the
remove-duplicate-constructor
branch
from
057ef7f to
3871ae2
Compare
|
Rebased. I agree with the inconsistency in zero-arity constructors. I'll bring it up for discussion in the Solidity repo. |
AugustoL
previously approved these changes
Dec 28, 2017
federicobond
force-pushed
the
remove-duplicate-constructor
branch
from
3871ae2 to
090e2fc
Compare
|
Rebased. |
ProphetDaniel
pushed a commit
to classicdelta/Smart-Contracts
that referenced
this pull request
Mar 9, 2018
…e-constructor Remove duplicated constructor call in FinalizableCrowdsaleImpl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is going to be enforced by the compiler soon.