Add checks to ERC7579Utils.decodeBatch #5353

Amxx · 2024-12-10T10:04:06Z

PR Checklist

Tests
Documentation
Changeset entry (run npx changeset add)

changeset-bot · 2024-12-10T10:04:10Z

⚠️ No Changeset found

Latest commit: 4d137e0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

…ch-decoding

contracts/account/utils/draft-ERC7579Utils.sol

test/account/utils/draft-ERC7579Utils.t.sol

contracts/account/utils/draft-ERC7579Utils.sol

Co-authored-by: Ernesto García <ernestognw@gmail.com>

contracts/account/utils/draft-ERC7579Utils.sol

test/account/utils/draft-ERC7579Utils.t.sol

contracts/account/utils/draft-ERC7579Utils.sol

Co-authored-by: Ernesto García <ernestognw@gmail.com> Co-authored-by: Francisco Giordano <fg@frang.io> Signed-off-by: Hadrien Croubois <hadrien.croubois@gmail.com>

Signed-off-by: Hadrien Croubois <hadrien.croubois@gmail.com> Co-authored-by: Ernesto García <ernestognw@gmail.com> Co-authored-by: Francisco Giordano <fg@frang.io>

Add checks to decodeBatch

76f6fc5

Amxx added the bug label Dec 10, 2024

Amxx added this to the 5.2-after-freeze milestone Dec 10, 2024

Amxx changed the title ~~Add checks to decodeBatch~~ Add checks to ERC7579Utils.decodeBatch Dec 10, 2024

Amxx added 5 commits December 10, 2024 16:00

Adapt POC to openzeppelin/contracts

4ec7f83

typo

b906509

Merge branch 'test/erc7579utils-decodeBatch-bug' into fix/ERC7579-bat…

c743f98

…ch-decoding

add foundry test

d0a6fbc

rewrite decode checks

10001f1

Amxx added the ignore-changeset label Dec 11, 2024

Amxx requested review from a team and frangio December 11, 2024 11:53

inline comments update

1d7f1c3

frangio reviewed Dec 11, 2024

View reviewed changes

contracts/account/utils/draft-ERC7579Utils.sol Outdated Show resolved Hide resolved

frangio reviewed Dec 11, 2024

View reviewed changes

contracts/account/utils/draft-ERC7579Utils.sol Show resolved Hide resolved

Amxx added 2 commits December 11, 2024 16:21

rewrite with less assembly

3bc90c7

codespell

72103ba

ernestognw reviewed Dec 11, 2024

View reviewed changes

test/account/utils/draft-ERC7579Utils.t.sol Show resolved Hide resolved

contracts/account/utils/draft-ERC7579Utils.sol Show resolved Hide resolved

contracts/account/utils/draft-ERC7579Utils.sol Outdated Show resolved Hide resolved

Amxx and others added 2 commits December 11, 2024 17:16

reorder parameters in ERC7579Utils.execXxx

456eb9a

Update contracts/account/utils/draft-ERC7579Utils.sol

63ee3ef

Co-authored-by: Ernesto García <ernestognw@gmail.com>

ernestognw reviewed Dec 11, 2024

View reviewed changes

contracts/account/utils/draft-ERC7579Utils.sol Outdated Show resolved Hide resolved

ernestognw reviewed Dec 11, 2024

View reviewed changes

contracts/account/utils/draft-ERC7579Utils.sol Show resolved Hide resolved

frangio reviewed Dec 11, 2024

View reviewed changes

contracts/account/utils/draft-ERC7579Utils.sol Outdated Show resolved Hide resolved

frangio reviewed Dec 11, 2024

View reviewed changes

contracts/account/utils/draft-ERC7579Utils.sol Outdated Show resolved Hide resolved

frangio reviewed Dec 11, 2024

View reviewed changes

contracts/account/utils/draft-ERC7579Utils.sol Outdated Show resolved Hide resolved

frangio reviewed Dec 11, 2024

View reviewed changes

contracts/account/utils/draft-ERC7579Utils.sol Outdated Show resolved Hide resolved

frangio added 3 commits December 11, 2024 18:52

add tests for decodeBatch

3363eb7

remove weird case

0c8e6eb

use variable

80da5b1

Amxx added 4 commits December 12, 2024 11:28

fix checks and tests

6aaa56a

fix lint

590e024

add credit to @adamegyed

7a7f8ce

comments

a8c93bd

frangio reviewed Dec 12, 2024

View reviewed changes

test/account/utils/draft-ERC7579Utils.t.sol Outdated Show resolved Hide resolved

frangio reviewed Dec 12, 2024

View reviewed changes

test/account/utils/draft-ERC7579Utils.t.sol Outdated Show resolved Hide resolved

frangio reviewed Dec 12, 2024

View reviewed changes

test/account/utils/draft-ERC7579Utils.t.sol Outdated Show resolved Hide resolved

frangio previously approved these changes Dec 12, 2024

View reviewed changes

minor update

a59a859

Amxx dismissed frangio’s stale review via a59a859 December 12, 2024 12:57

Amxx requested review from adamegyed, ernestognw and frangio December 12, 2024 12:57

frangio previously approved these changes Dec 12, 2024

View reviewed changes

Amxx mentioned this pull request Dec 12, 2024

Vendor entrypoint bytecode #5362

Merged

3 tasks

minimize imports

4622965

Amxx dismissed frangio’s stale review via 4622965 December 12, 2024 14:43

Amxx added 3 commits December 12, 2024 16:21

Merge branch 'master' into fix/ERC7579-batch-decoding

cc6bdc6

apply seppi's recommendation

35c74ab

up

4800b82

Amxx commented Dec 12, 2024

View reviewed changes

contracts/account/utils/draft-ERC7579Utils.sol Outdated Show resolved Hide resolved

Amxx and others added 3 commits December 12, 2024 18:27

rewrite

cfcebc9

rewrite

ef44c81

Rename offset -> arrayLengthOffset

4d137e0

ernestognw approved these changes Dec 12, 2024

View reviewed changes

ernestognw merged commit 77d4a73 into OpenZeppelin:master Dec 12, 2024
17 checks passed

Amxx deleted the fix/ERC7579-batch-decoding branch December 13, 2024 08:35

Amxx added a commit that referenced this pull request Dec 16, 2024

Cherrypick #5353 into release-v5.2 (#5367)

ab96c48

Signed-off-by: Hadrien Croubois <hadrien.croubois@gmail.com> Co-authored-by: Ernesto García <ernestognw@gmail.com> Co-authored-by: Francisco Giordano <fg@frang.io>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add checks to ERC7579Utils.decodeBatch #5353

Add checks to ERC7579Utils.decodeBatch #5353

Uh oh!

Amxx commented Dec 10, 2024 •

edited

Loading

Uh oh!

changeset-bot bot commented Dec 10, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Add checks to ERC7579Utils.decodeBatch #5353

Add checks to ERC7579Utils.decodeBatch #5353

Uh oh!

Conversation

Amxx commented Dec 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Checklist

Uh oh!

changeset-bot bot commented Dec 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Amxx commented Dec 10, 2024 •

edited

Loading

changeset-bot bot commented Dec 10, 2024 •

edited

Loading