Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various changes to code clarity (Fix N-07) #5317

Merged
merged 11 commits into from
Nov 27, 2024
Merged

Various changes to code clarity (Fix N-07) #5317

merged 11 commits into from
Nov 27, 2024

Conversation

Amxx
Copy link
Collaborator

@Amxx Amxx commented Nov 25, 2024

Fixes N-07

PR Checklist

  • Tests
  • Documentation
  • Changeset entry (run npx changeset add)

@Amxx Amxx added this to the 5.2-after-freeze milestone Nov 25, 2024
@Amxx Amxx requested a review from ernestognw November 25, 2024 10:31
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 25, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 7a3707f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

ernestognw
ernestognw previously approved these changes Nov 26, 2024
View reviewed changes
ernestognw
ernestognw previously approved these changes Nov 26, 2024
View reviewed changes
@ernestognw ernestognw requested a review from arr00 November 26, 2024 18:15
ernestognw
ernestognw previously approved these changes Nov 27, 2024
View reviewed changes
arr00
arr00 previously approved these changes Nov 27, 2024
View reviewed changes
ernestognw
ernestognw previously approved these changes Nov 27, 2024
View reviewed changes
@ernestognw ernestognw dismissed stale reviews from arr00 and themself via 7a3707f November 27, 2024 20:25
@ernestognw ernestognw merged commit 653963b into OpenZeppelin:master Nov 27, 2024
15 checks passed
Amxx added a commit to Amxx/openzeppelin-contracts that referenced this pull request Nov 30, 2024
@Amxx @ernestognw @arr00
Various changes to code clarity (Fix N-07) (OpenZeppelin#5317)
b196291 
Co-authored-by: Ernesto García <ernestognw@gmail.com>
Co-authored-by: Arr00 <13561405+arr00@users.noreply.github.com>
Signed-off-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Amxx added a commit to Amxx/openzeppelin-contracts that referenced this pull request Nov 30, 2024
@Amxx @ernestognw @arr00
Various changes to code clarity (Fix N-07) (OpenZeppelin#5317)
a2dfd87 
Co-authored-by: Ernesto García <ernestognw@gmail.com>
Co-authored-by: Arr00 <13561405+arr00@users.noreply.github.com>
Signed-off-by: Hadrien Croubois <hadrien.croubois@gmail.com>
@Amxx Amxx deleted the fix/n-07 branch December 11, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ernestognw ernestognw ernestognw approved these changes

@arr00 arr00 arr00 left review comments

Assignees
No one assigned
Labels
ignore-changeset
Projects
None yet
Milestone
5.2-after-freeze
Development

Successfully merging this pull request may close these issues.
3 participants
@Amxx @arr00 @ernestognw