ERC20: optimized gas costs in _spendAllowance

[XZSt4nce]

Fixes #5253
Used less-than operator instead of not-equal:
currentAllowance < type(uint256).max
instead of
currentAllowance != type(uint256).max

PR Checklist

• Tests
• Documentation
• Changeset entry (run npx changeset add)

[changeset-bot]

⚠️ No Changeset found

Latest commit: 6e9aabf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[cairoeth]

@XZSt4nce can you provide concrete benchmarks on this change? I'm not too sure the gas difference will be even slightly significant.

[XZSt4nce]

@cairoeth 36 gas diff

[gitpoap-bot]

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2024 OpenZeppelin Contracts Contributor:

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.