Skip to content

Conversation

@Amxx
Copy link
Collaborator

@Amxx Amxx commented Oct 11, 2024

Depends on #5166

PR Checklist

  • Tests
  • Documentation
  • Changeset entry (run npx changeset add)

@changeset-bot
Copy link

changeset-bot bot commented Oct 11, 2024

🦋 Changeset detected

Latest commit: 170a48c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
openzeppelin-solidity Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Amxx and others added 5 commits October 11, 2024 21:28
Co-authored-by: cairo <cairoeth@protonmail.com>
Co-authored-by: cairo <cairoeth@protonmail.com>
@Amxx Amxx force-pushed the features/caip-helpers branch from eb938da to 88ee5a4 Compare October 14, 2024 09:38
@Amxx Amxx mentioned this pull request Oct 14, 2024
3 tasks
@Amxx Amxx requested review from arr00, cairoeth and ernestognw October 14, 2024 19:38
@Amxx Amxx changed the title CAIP helpers Bytes library and CAIP2/CAIP10 helpers Oct 14, 2024
ernestognw
ernestognw previously approved these changes Oct 14, 2024
Copy link
Member

@ernestognw ernestognw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly good, nits for the documentation

Co-authored-by: Ernesto García <ernestognw@gmail.com>
Co-authored-by: Arr00 <13561405+arr00@users.noreply.github.com>
@Amxx Amxx merged commit fe6249e into master Oct 14, 2024
@Amxx Amxx deleted the features/caip-helpers branch October 14, 2024 20:41
ernestognw added a commit that referenced this pull request Oct 14, 2024
Co-authored-by: cairo <cairoeth@protonmail.com>
Co-authored-by: Ernesto García <ernestognw@gmail.com>
Co-authored-by: Arr00 <13561405+arr00@users.noreply.github.com>
@cairoeth cairoeth added this to the 5.2 milestone Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants