Disallow empty CircularBuffer setup

[ernestognw]

Fixes N-12

PR Checklist

• Tests
• Documentation
• Changeset entry (run npx changeset add)

[changeset-bot]

⚠️ No Changeset found

Latest commit: 3eb56a6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[cairoeth]

was it concluded to skip a check that buffer was setup in push?

[Amxx]

was it concluded to skip a check that buffer was setup in push?

If you push to a buffer of length 0 (not setup), then you get a panic error DIVISION_BY_ZERO because of the modulus operation. We consiedered adding a check that would trigger a different panic ... but the cost is not really worth it.

So we agree to not put any manual check and just rely on the modulo panicking.

[GIgako19929]