Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify mapping named parameters #5204

Merged
merged 3 commits into from
Sep 19, 2024
Merged

Clarify mapping named parameters #5204

merged 3 commits into from
Sep 19, 2024

Conversation

cairoeth
Copy link
Contributor

@cairoeth cairoeth commented Sep 16, 2024 •
edited
Loading

Fixes N03.

PR Checklist

  • Tests
  • Documentation
  • Changeset entry (run npx changeset add)

@cairoeth cairoeth added this to the 5.1-after-freeze milestone Sep 16, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 16, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 336d7f8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Amxx Amxx merged commit f3825ab into OpenZeppelin:master Sep 19, 2024
21 checks passed
Amxx pushed a commit to Amxx/openzeppelin-contracts that referenced this pull request Oct 1, 2024
@cairoeth @Amxx
Clarify mapping named parameters (OpenZeppelin#5204)
fa0d643 
Signed-off-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Amxx pushed a commit that referenced this pull request Oct 2, 2024
@cairoeth @Amxx
Clarify mapping named parameters (#5204)
26b056d 
Signed-off-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frangio frangio frangio left review comments

@ernestognw ernestognw ernestognw approved these changes

@Amxx Amxx Amxx approved these changes

Assignees
No one assigned
Labels
ignore-changeset
Projects
None yet
Milestone
5.1-after-freeze
Development

Successfully merging this pull request may close these issues.
4 participants
@cairoeth @frangio @Amxx @ernestognw