Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify Governor events' lack of indexed parameters #5175

Merged
merged 4 commits into from
Sep 5, 2024
Merged

Clarify Governor events' lack of indexed parameters #5175

merged 4 commits into from
Sep 5, 2024

Conversation

ernestognw
Copy link
Member

Fixes N-01

PR Checklist

  • Tests
  • Documentation
  • Changeset entry (run npx changeset add)

@ernestognw ernestognw added this to the 5.1-after-freeze milestone Aug 29, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 29, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: ab33340

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ernestognw ernestognw requested a review from Amxx August 29, 2024 19:31
ernestognw and others added 2 commits August 30, 2024 09:20
@ernestognw @Amxx
Update contracts/governance/IGovernor.sol
a68a657 
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
@ernestognw
Lint
33aabe5
@ernestognw @Amxx
Update contracts/governance/IGovernor.sol
ab33340 
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
@ernestognw ernestognw requested a review from Amxx September 3, 2024 17:38
@ernestognw ernestognw enabled auto-merge (squash) September 5, 2024 18:36
cairoeth
cairoeth approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@cairoeth cairoeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ernestognw ernestognw merged commit 55d6957 into OpenZeppelin:master Sep 5, 2024
21 checks passed
Amxx added a commit to Amxx/openzeppelin-contracts that referenced this pull request Oct 1, 2024
@ernestognw @Amxx
Clarify Governor events' lack of indexed parameters (OpenZeppelin#5175)
56c61cc 
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Signed-off-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Amxx added a commit that referenced this pull request Oct 2, 2024
@ernestognw @Amxx
Clarify Governor events' lack of indexed parameters (#5175)
82bddf5 
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Signed-off-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cairoeth cairoeth cairoeth approved these changes

@Amxx Amxx Awaiting requested review from Amxx

Assignees
No one assigned
Labels
ignore-changeset
Projects
None yet
Milestone
5.1-after-freeze
Development

Successfully merging this pull request may close these issues.
3 participants
@ernestognw @Amxx @cairoeth