-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add note about 100% royalty in IERC2981 #5173
Conversation
|
contracts/interfaces/IERC2981.sol
Outdated
* NOTE: Consider 100% royalty is a valid scenario, therefore contracts performing a royalty transfer with the value | ||
* returned by this function may want to check for 0 value transfers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* NOTE: Consider 100% royalty is a valid scenario, therefore contracts performing a royalty transfer with the value | |
* returned by this function may want to check for 0 value transfers. | |
* NOTE: ERC-2981 authorizes setting the royalty to 100% of the price. In that scenario all the price would go | |
* toward the royalty receiver, and no tokens would go the the seller. Contracts dealing with royalty should | |
* consider that the transfer of value toward the seller might be empty. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm keeping it, but changing it to two lines, lmk if it doesn't work
suggestion
* NOTE: Consider 100% royalty is a valid scenario, therefore contracts performing a royalty transfer with the value | |
* returned by this function may want to check for 0 value transfers. | |
* NOTE: ERC-2981 allows setting the royalty to 100% of the price. In that case, all the price would be sent to the | |
* royalty receiver and 0 tokens to the seller. Contracts dealing with royalty should consider empty transfers. |
Signed-off-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Signed-off-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Fixes L-01
PR Checklist
npx changeset add
)