Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use free memory pointer for returndatacopy #5057

Merged
merged 1 commit into from
May 27, 2024

Conversation

frangio
Copy link
Contributor

@frangio frangio commented May 27, 2024

Fixing memory safety as explained here: https://github.com/OpenZeppelin/openzeppelin-contracts/pull/5052/files#r1616302783

The Solidity docs state:

these restrictions still need to be followed, even if the assembly block reverts or terminates.

Copy link

changeset-bot bot commented May 27, 2024

⚠️ No Changeset found

Latest commit: 5a979b3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@frangio
Copy link
Contributor Author

frangio commented May 27, 2024

Does this need a changeset?

Copy link
Member

@ernestognw ernestognw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need a changeset?

I don't think so

@Amxx Amxx merged commit a241f09 into OpenZeppelin:master May 27, 2024
24 of 25 checks passed
Copy link

gitpoap-bot bot commented May 27, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2024 OpenZeppelin Contracts Contributor:

GitPOAP: 2024 OpenZeppelin Contracts Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@frangio frangio deleted the fix-memory-safe-create2 branch May 27, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants