Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace custom errors with native panic codes in DoubleEndedQueue #4872

Merged
merged 5 commits into from
Feb 6, 2024
Merged

Replace custom errors with native panic codes in DoubleEndedQueue #4872

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
20ad305
Replace custom errors with native panic codes in DoubleEndedQueue
Amxx Feb 2, 2024
5a43ef4
lint
Amxx Feb 2, 2024
9027fb8
fix tests
Amxx Feb 2, 2024
eae2272
Add internal variables to docs
ernestognw Feb 6, 2024
16c52e5
Reference Panic library in DoubleEndedQueue
ernestognw Feb 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Reference Panic library in DoubleEndedQueue
  • Loading branch information
@ernestognw
ernestognw committed Feb 6, 2024
commit 16c52e59d582ce082b75c246c6cf94dfa415b490
14 changes: 7 additions & 7 deletions contracts/utils/structs/DoubleEndedQueue.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ library DoubleEndedQueue {
/**
* @dev Inserts an item at the end of the queue.
*
* Reverts with {RESOURCE_ERROR} panic code if the queue is full.
* Reverts with {Panic-RESOURCE_ERROR} if the queue is full.
*/
function pushBack(Bytes32Deque storage deque, bytes32 value) internal {
unchecked {
Expand All @@ -49,7 +49,7 @@ library DoubleEndedQueue {
/**
* @dev Removes the item at the end of the queue and returns it.
*
* Reverts with {EMPTY_ARRAY_POP} panic code if the queue is empty.
* Reverts with {Panic-EMPTY_ARRAY_POP} if the queue is empty.
*/
function popBack(Bytes32Deque storage deque) internal returns (bytes32 value) {
unchecked {
Expand All @@ -65,7 +65,7 @@ library DoubleEndedQueue {
/**
* @dev Inserts an item at the beginning of the queue.
*
* Reverts with {RESOURCE_ERROR} panic code if the queue is full.
* Reverts with {Panic-RESOURCE_ERROR} if the queue is full.
*/
function pushFront(Bytes32Deque storage deque, bytes32 value) internal {
unchecked {
Expand All @@ -79,7 +79,7 @@ library DoubleEndedQueue {
/**
* @dev Removes the item at the beginning of the queue and returns it.
*
* Reverts with `EMPTY_ARRAY_POP` panic code if the queue is empty.
* Reverts with {Panic-EMPTY_ARRAY_POP} if the queue is empty.
*/
function popFront(Bytes32Deque storage deque) internal returns (bytes32 value) {
unchecked {
Expand All @@ -94,7 +94,7 @@ library DoubleEndedQueue {
/**
* @dev Returns the item at the beginning of the queue.
*
* Reverts with `ARRAY_OUT_OF_BOUNDS` panic code if the queue is empty.
* Reverts with {Panic-ARRAY_OUT_OF_BOUNDS} if the queue is empty.
*/
function front(Bytes32Deque storage deque) internal view returns (bytes32 value) {
if (empty(deque)) Panic.panic(Panic.ARRAY_OUT_OF_BOUNDS);
Expand All @@ -104,7 +104,7 @@ library DoubleEndedQueue {
/**
* @dev Returns the item at the end of the queue.
*
* Reverts with `ARRAY_OUT_OF_BOUNDS` panic code if the queue is empty.
* Reverts with {Panic-ARRAY_OUT_OF_BOUNDS} if the queue is empty.
*/
function back(Bytes32Deque storage deque) internal view returns (bytes32 value) {
if (empty(deque)) Panic.panic(Panic.ARRAY_OUT_OF_BOUNDS);
Expand All @@ -117,7 +117,7 @@ library DoubleEndedQueue {
* @dev Return the item at a position in the queue given by `index`, with the first item at 0 and last item at
* `length(deque) - 1`.
*
* Reverts with `ARRAY_OUT_OF_BOUNDS` panic code if the index is out of bounds.
* Reverts with {Panic-ARRAY_OUT_OF_BOUNDS} if the index is out of bounds.
*/
function at(Bytes32Deque storage deque, uint256 index) internal view returns (bytes32 value) {
if (index >= length(deque)) Panic.panic(Panic.ARRAY_OUT_OF_BOUNDS);
Expand Down
Loading