Fix release tagging #4646
Merged
Fix release tagging #4646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Amxx
approved these changes
Oct 3, 2023
ernestognw
reviewed
Oct 3, 2023
| @@ -147,16 +147,12 @@ jobs: | |||
| with: | |||
| name: ${{ github.ref_name }} | |||
| path: ${{ steps.pack.outputs.tarball }} | |||
| - name: Tag | |||
| run: npx changeset tag | |||
There was a problem hiding this comment.
Isn't this creating the actual changelog?
ernestognw
approved these changes
Oct 3, 2023
frangio
added a commit
that referenced
this pull request
Oct 3, 2023
(cherry picked from commit 5d43060)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're having an issue with automated releases where the tag that gets created in the process is not correctly assigned to the release commit (even though the rest of the release is all done correctly). We believe this is because
npx changeset tag; git push --tagsis either not creating the tag or not pushing it correctly, causing the subsequentcreateReleaseAPI call ingithub-release.jsto create the tag in the default branch. This PR removes the manual tagging and relies oncreateReleaseby specifying thetarget_commitishoption (docs here).