Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge branch 'release-v4.9' into master #4373

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

frangio
Copy link
Contributor

@frangio frangio commented Jun 19, 2023

This brings the latest changes from release-v4.9 including the changelog and version header updates.

This part of our release workflow is broken, as can be seen in #4366. Due to squashing these merge commits, resolved conflicts are "forgotten" and for each new patch we have to re-resolve them. I don't have a sustainable solution for this yet. In the meantime I did the merge manually.

@frangio frangio requested a review from a team June 19, 2023 22:57
@changeset-bot
Copy link

changeset-bot bot commented Jun 19, 2023

⚠️ No Changeset found

Latest commit: 8b9643c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@ernestognw ernestognw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Amxx
Copy link
Collaborator

Amxx commented Jun 20, 2023

should this be squash or merged "normally" ?

@frangio frangio merged commit b66c77a into OpenZeppelin:master Jun 20, 2023
@frangio frangio deleted the manual-merge/release-v4.9 branch June 20, 2023 16:06
@frangio
Copy link
Contributor Author

frangio commented Jun 20, 2023

Squashed for now until we come up with a better alternative.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants