Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor DoubleEndedQueue #4150

Merged
merged 14 commits into from
Jul 27, 2023
Merged

Refactor DoubleEndedQueue #4150

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
fd880a5
remove signed integers from DoubleEndedQueue
Amxx Mar 31, 2023
1199e60
Merge branch 'master' into refactor/DoubleEndedQueue
Amxx Jun 28, 2023
1294d4b
Update DoubleEndedQueue.sol
Amxx Jul 7, 2023
734bf8e
Merge branch 'master' into refactor/DoubleEndedQueue
Amxx Jul 7, 2023
0b3da8c
update DoubleEndedQueue specs to run with certora 4.3.1
Amxx Jul 7, 2023
2201f65
remove declaration of max_uint48 with is not available by default in …
Amxx Jul 7, 2023
909af00
add changeset
Amxx Jul 8, 2023
d5b67d3
Update strong-poems-thank.md
Amxx Jul 8, 2023
3b3e144
Merge branch 'master' into refactor/DoubleEndedQueue
Amxx Jul 25, 2023
8c64c4c
Update contracts/utils/structs/DoubleEndedQueue.sol
Amxx Jul 26, 2023
aea94da
Merge branch 'master' into refactor/DoubleEndedQueue
Amxx Jul 26, 2023
825d8fe
remove safecast
Amxx Jul 26, 2023
53ac10d
fix lint
Amxx Jul 26, 2023
3a2ec00
edit comment
frangio Jul 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update DoubleEndedQueue.sol
  • Loading branch information
@Amxx
Amxx authored Jul 7, 2023
commit 1294d4bc10863ed6bcc0e3153f298883a3ced912
6 changes: 3 additions & 3 deletions contracts/utils/structs/DoubleEndedQueue.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ library DoubleEndedQueue {
/**
* @dev A push operation couldn't be completed due to the queue being full.
*/
error Full();
error QueueFull();

/**
* @dev An operation (e.g. {at}) couldn't be completed due to an index being out of bounds.
Expand Down Expand Up @@ -58,7 +58,7 @@ library DoubleEndedQueue {
function pushBack(Bytes32Deque storage deque, bytes32 value) internal {
unchecked {
uint128 backIndex = deque._end;
if (backIndex + 1 == deque._begin) revert Full();
if (backIndex + 1 == deque._begin) revert QueueFull();
deque._data[backIndex] = value;
deque._end = backIndex + 1;
}
Expand Down Expand Up @@ -86,7 +86,7 @@ library DoubleEndedQueue {
function pushFront(Bytes32Deque storage deque, bytes32 value) internal {
unchecked {
uint128 frontIndex = deque._begin - 1;
if (frontIndex == deque._end) revert Full();
if (frontIndex == deque._end) revert QueueFull();
deque._data[frontIndex] = value;
deque._begin = frontIndex;
}
Expand Down