Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify ERC721Wrapper.depositFor to save gas #4048

Merged
merged 7 commits into from
Feb 17, 2023
Merged

Simplify ERC721Wrapper.depositFor to save gas #4048

merged 7 commits into from
Feb 17, 2023

Conversation

Amxx
Copy link
Collaborator

@Amxx Amxx commented Feb 15, 2023 •
edited
Loading

This PR reduces the gas cost of depositing tokens into a ERC721Wrapper (using the depositFor function) by about 3.2k gas per token. (see test report)

Fixes LIB-701

PR Checklist

  • Tests

@changeset-bot
Copy link

changeset-bot bot commented Feb 15, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: b148973

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Amxx Amxx changed the title Simplificaty ERC721Wrapper.depositFor to save gas. Simplify ERC721Wrapper.depositFor to save gas. Feb 15, 2023
@Amxx Amxx requested review from frangio and ernestognw February 16, 2023 09:37
@frangio
Copy link
Contributor

frangio commented Feb 16, 2023

Another simplification we have to make is remove ERC721Holder and inherit IERC721Receiver directly, since we're fully overriding it.

@frangio frangio changed the title Simplify ERC721Wrapper.depositFor to save gas. Simplify ERC721Wrapper.depositFor to save gas Feb 16, 2023
frangio
frangio approved these changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ernestognw
ernestognw approved these changes Feb 16, 2023
View reviewed changes
Copy link
Member

@ernestognw ernestognw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@frangio frangio merged commit d5d9d4b into OpenZeppelin:master Feb 17, 2023
@Amxx Amxx deleted the refactor/gas/erc721wrapper branch February 17, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ernestognw ernestognw ernestognw approved these changes

@frangio frangio frangio approved these changes

Assignees
No one assigned
Labels
ignore-changeset
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Amxx @frangio @ernestognw