Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix governance tutorial contract #3948

Merged
merged 3 commits into from
Jan 12, 2023
Merged

Fix governance tutorial contract #3948

merged 3 commits into from
Jan 12, 2023

Conversation

omurovec
Copy link
Contributor

@omurovec omurovec commented Jan 11, 2023 •
edited
Loading

Fixes #3947

Fixes typo in governance docs which causes example to fail to compile.

PR Checklist

  • Tests
  • Documentation
  • Changelog entry

@Amxx
Copy link
Collaborator

Amxx commented Jan 11, 2023

Hello @omurovec, and thank you for raising this.

AFAIK, this should probably not be overridden at all. I'll see if that can't be cleaned up even further

@omurovec
Copy link
Contributor Author

Great! Was also planning to create a duplicate issue in the upgradeable repo since I believe it has the same issue.
@Amxx

@frangio
Copy link
Contributor

frangio commented Jan 11, 2023 •
edited
Loading

Pretty sure this was broken due to the changes to getVotes in 4.6.0.

I noticed that the imports were wrong as well so included that in this PR.

Was also planning to create a duplicate issue in the upgradeable repo since I believe it has the same issue.

There's no need to do this. The upgradeable repo will update once we fix it here.

frangio
frangio previously approved these changes Jan 11, 2023
View reviewed changes
@frangio frangio changed the title Fix governance docs typo #3947 Fix governance tutorial contract Jan 11, 2023
@frangio frangio mentioned this pull request Jan 12, 2023
Open
frangio
frangio approved these changes Jan 12, 2023
View reviewed changes
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting that seems to compile as well. Opened OpenZeppelin/contracts-wizard#218.

@frangio frangio merged commit 5dbde1a into OpenZeppelin:master Jan 12, 2023
@gitpoap-bot
Copy link

gitpoap-bot bot commented Jan 12, 2023

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2023 OpenZeppelin Contracts Contributor:

GitPOAP: 2023 OpenZeppelin Contracts Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

frangio pushed a commit that referenced this pull request Jan 12, 2023
@omurovec @frangio
Fix governance tutorial contract (#3948)
873a01b 
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
(cherry picked from commit 5dbde1a)
@omurovec omurovec deleted the fix/governance-docs-typo-#3947 branch January 19, 2023 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frangio frangio frangio approved these changes

Assignees
No one assigned
Labels
ignore-changeset
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Governor docs example fails to compile
3 participants
@omurovec @Amxx @frangio