Remove ERC1155 hooks #3876
Merged
Remove ERC1155 hooks #3876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
what about erc721? will it be different from 20 and 1155? |
Contributor
Author
Thanks for showing interest. It will be worked on after this to use the same |
Contributor
|
@TrejGun Keep in mind that this is planned for 5.0 release which is still months away. |
…com/JulissaDantes/openzeppelin-contracts into refactor/erc1155-mint-transfer-burn
Amxx
reviewed
Jan 6, 2023
Amxx
reviewed
Jan 6, 2023
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
This was referenced Sep 10, 2024
This was referenced Sep 12, 2024
This was referenced Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3535
The current way to customize token transfers(mint, burn, transfer) is by overriding the hooks _beforeTokenTransfer and _afterTokenTransfer. This refactor removes both hooks from the ERC1155 contract, and implements the logic inside the new
_updateinternal function, so future customizations only rely on overriding a single entry point.PR Checklist