Update blurb on GovernorVotes compatibility #3764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since v4.5, GovernorVotes supports ERC721Votes tokens- this is detailed in the ERC721Votes API documentation but not in the Governor documentation, which is where developers like myself land first. The result is confusion about whether or not OZ Governor contracts can support ERC721 in addition to ERC20. Developers may come to the Governor documentation, assume only ERC20Votes is supported, and then decide to look elsewhere for ERC721 governance (this happened to me) Updating the blurb as shown fixes this
JulissaDantes
approved these changes
Oct 20, 2022
frangio
approved these changes
Dec 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since v4.5, GovernorVotes supports ERC721Votes tokens- this is detailed in the ERC721Votes API documentation but not in the Governor documentation, which is where developers like myself land first.
The result is confusion about whether or not OZ Governor contracts can support ERC721 in addition to ERC20. Developers may come to the Governor documentation, assume only ERC20Votes is supported, and then decide to look elsewhere for ERC721 governance (this happened to me)
Updating the blurb as shown fixes this
Fixes #????
PR Checklist