Skip to content

[next-v5.0] Refactor voting, adding a Nonce contract #3638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 12 commits into from

Conversation

Amxx
Copy link
Collaborator

@Amxx Amxx commented Aug 19, 2022

Replaces #3471

PR Checklist

  • Tests
  • Documentation
  • Changelog entry

@socket-security
Copy link

socket-security bot commented Oct 31, 2022

Socket Security Pull Request Report

👍 No dependency changes detected in pull request

Pull request report summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script confusion ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

Powered by socket.dev

@JulissaDantes
Copy link
Contributor

This branch was rebased.

@JulissaDantes
Copy link
Contributor

This work will continue in #3816

@k06a
Copy link
Contributor

k06a commented Dec 2, 2022

What do you think about implementing Nonces as library and using different instances within one smart contract for permits and votes and anything else?

@Amxx Amxx deleted the refactor/ERC20Votes branch January 2, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants