Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor magic constant in TimelocController test #3397

Merged
merged 1 commit into from
May 12, 2022
Merged

Refactor magic constant in TimelocController test #3397

merged 1 commit into from
May 12, 2022

Conversation

onlineSoftwareDevOK
Copy link
Contributor

@onlineSoftwareDevOK onlineSoftwareDevOK commented May 5, 2022 •
edited by Amxx
Loading

Fixes #3297

PR Checklist

  • Tests
  • Documentation
  • Changelog entry

Amxx
Amxx approved these changes May 5, 2022
View reviewed changes
Copy link
Collaborator

@Amxx Amxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @onlineSoftwareDevOK for this PR.

@Amxx Amxx changed the title Fix issue 3297 Refactor magic constant in TimelocController test May 12, 2022
@Amxx Amxx enabled auto-merge (squash) May 12, 2022 22:14
@Amxx Amxx merged commit cd2da98 into OpenZeppelin:master May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Amxx Amxx Amxx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Give names to magic values in TimelockController tests
2 participants
@onlineSoftwareDevOK @Amxx