-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add memory safe assembly annotations #3384
Add memory safe assembly annotations #3384
Conversation
Thank you @nathan-lapinski! A few comments:
|
Sounds good. Thank you for the review, @frangio ! I will add a few more files to this PR before requesting another review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This looks good. Do you want to add the remaining files from #3336 (comment) ?
Thanks for the review @frangio ! Yes, I’ll go ahead and add the remaining files to this PR. |
This covers all of the inline If it looks safe, I'd be happy to add it to this PR, or at least add a comment mentioning why it wasn't marked as memory-safe. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! The Proxy assembly block shouldn't make a difference.
Part of #3336
Adds memory safe annotations for blocks of inline assembly in the following files:
SafeMathMock.solAs discussed here, I am happy to add more files into this PR before merging, but I wanted to open this now to gather feedback.
This is also my first contribution to this repository, so please let me know if I have made any errors.🙏
PR Checklist