Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inherit ERC20Wrapper decimals from the underlying #3259

Merged
merged 2 commits into from
Mar 22, 2022
Merged

Inherit ERC20Wrapper decimals from the underlying #3259

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73c6598
improve wrapper decimal support
Amxx Mar 10, 2022
f58f39c
Update test/token/ERC20/extensions/ERC20Wrapper.test.js
Amxx Mar 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update test/token/ERC20/extensions/ERC20Wrapper.test.js 
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
  • Loading branch information
@Amxx @frangio
Amxx and frangio authored Mar 10, 2022
commit f58f39cca58688f6e35fa66055f47ca5cc80e5e9
6 changes: 3 additions & 3 deletions test/token/ERC20/extensions/ERC20Wrapper.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,9 @@ contract('ERC20', function (accounts) {
});

it('decimals default back to 18 if token has no metadata', async function () {
this.nodecimals = await NotAnERC20.new();
this.othertoken = await ERC20WrapperMock.new(this.nodecimals.address, `Wrapped ${name}`, `W${symbol}`);
expect(await this.othertoken.decimals()).to.be.bignumber.equal('18');
const noDecimals = await NotAnERC20.new();
const otherToken = await ERC20WrapperMock.new(noDecimals.address, `Wrapped ${name}`, `W${symbol}`);
expect(await otherToken.decimals()).to.be.bignumber.equal('18');
});

it('has underlying', async function () {
Expand Down