Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move abs(int256) from Math to SignedMath #3110

Merged
merged 2 commits into from
Jan 14, 2022

Conversation

Amxx
Copy link
Collaborator

@Amxx Amxx commented Jan 14, 2022

To cherrypick on 4.5.0-rc.0

Improve #2984 considering #2686

PR Checklist

  • Tests
  • Changelog entry

frangio
frangio previously approved these changes Jan 14, 2022
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some linter errors but is good otherwise.

@frangio frangio changed the title Move abs(uint256) from Math to SafeMath Move abs(int256) from Math to SafeMath Jan 14, 2022
@frangio frangio enabled auto-merge (squash) January 14, 2022 22:18
@frangio frangio merged commit 3eb2d43 into OpenZeppelin:master Jan 14, 2022
@Amxx Amxx deleted the refactor/math2signedmath branch January 15, 2022 23:58
@Amxx Amxx mentioned this pull request Jan 25, 2022
Amxx added a commit that referenced this pull request Feb 8, 2022
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
(cherry picked from commit 3eb2d43)
Signed-off-by: Hadrien Croubois <hadrien.croubois@gmail.com>
@frangio frangio changed the title Move abs(int256) from Math to SafeMath Move abs(int256) from Math to SignedMath Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants