Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid assembly in signature V and S decomposition #3060

Merged
merged 2 commits into from
Dec 29, 2021

Conversation

k06a
Copy link
Contributor

@k06a k06a commented Dec 29, 2021

Is there any specific reason why assembly was used here?

PR Checklist

  • Tests
  • Documentation
  • Changelog entry

@Amxx
Copy link
Collaborator

Amxx commented Dec 29, 2021

Not really. It beeing used extensively in the same file might explain how we were drawn to it initially, but it is true we could use native solidity here. I don't expect it to be much more expensive.

@k06a
Copy link
Contributor Author

k06a commented Dec 29, 2021

I find assembly useful for converting bytes to uint256/bytes32. I see most of the cases in this file are for this purpose.

Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Amxx Amxx merged commit da3a9ae into OpenZeppelin:master Dec 29, 2021
@k06a k06a deleted the patch-8 branch December 29, 2021 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants