Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support london with coverage using initialBaseFee = 0 #2838

Merged
merged 3 commits into from
Aug 30, 2021

Conversation

Amxx
Copy link
Collaborator

@Amxx Amxx commented Aug 30, 2021

Do not revert to berlin for coverage, instead, just set initialBaseGasFee to 0.

Will be handy if we ever need to use opcodes introduced after berlin in contracts.

Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@frangio frangio merged commit fb36326 into OpenZeppelin:master Aug 30, 2021
@Amxx Amxx deleted the improvement/coverage-london branch October 20, 2021 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants