Skip to content

Allow Ownable to work with meta-trasnactions (ERC2771Context) #2739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
drortirosh wants to merge 1 commit into from
Closed

Allow Ownable to work with meta-trasnactions (ERC2771Context) #2739

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion contracts/access/Ownable.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,11 @@ abstract contract Ownable is Context {
* @dev Initializes the contract setting the deployer as the initial owner.
*/
constructor() {
_setOwner(_msgSender());
// this is one of the only places that _msgSender() should NOT be used:
// a constructor can't be called directly through meta-transactions.
// and also _msgSender() references a member (_trustedForwrader) - which is forbidden
// from a constructor call..
_setOwner(msg.sender);
}

/**
Expand Down