Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use shorter syntax for Escrow addition #2646

Merged
merged 5 commits into from
May 4, 2021
Merged

Use shorter syntax for Escrow addition #2646

merged 5 commits into from
May 4, 2021

Conversation

Manik-Jain
Copy link
Contributor

@Manik-Jain Manik-Jain commented Apr 27, 2021 •
edited by frangio
Loading

Using short hand notation for add operation

Fixes #2659

PR Checklist

  • Tests
  • Documentation
  • Changelog entry

@Manik-Jain
Update Escrow.sol
0cf7578 
Using short hand notation for add operation
@Manik-Jain
Update Escrow.sol
9bced48
@Manik-Jain
Copy link
Contributor Author

Hi @frangio

Could this be reviewed?

@frangio
Copy link
Contributor

frangio commented May 4, 2021

@Manik-Jain Can you make this PR only about the += operator, and if you think we're missing these require statements create an issue to discuss it separately.

@Manik-Jain
Copy link
Contributor Author

Change done. Yes, I missed to create the Issue for this change.
I've created the issue under listing : #2659

Thanks

frangio
frangio approved these changes May 4, 2021
View reviewed changes
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@frangio frangio changed the title Update Escrow.sol Use shorter syntax for Escrow addition May 4, 2021
@frangio frangio enabled auto-merge (squash) May 4, 2021 19:55
@frangio frangio merged commit 1dc4a31 into OpenZeppelin:master May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frangio frangio frangio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cosmetic change in Escrow.sol
2 participants
@Manik-Jain @frangio