Skip to content

Conversation

@Amxx
Copy link
Collaborator

@Amxx Amxx commented Mar 5, 2021

Fixes #2564

PR Checklist

  • Tests
  • Documentation
  • Changelog entry

@Amxx Amxx changed the title Feature/erc20 permit increment internal Add an internal _useNonce(address) function in ERC20Permit Mar 5, 2021
@frangio
Copy link
Contributor

frangio commented Mar 8, 2021

nonces should be made virtual now that it is possible to override _useNonce.

@Amxx Amxx force-pushed the feature/ERC20PermitIncrementInternal branch from 62219e2 to a8ab6ff Compare March 10, 2021 14:31
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@frangio frangio merged commit 5171e46 into OpenZeppelin:master Mar 10, 2021
@Amxx Amxx deleted the feature/ERC20PermitIncrementInternal branch March 10, 2021 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add an internal _useNonce(address) function in ERC20Permit

2 participants