Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Strings.toHexString function #2504

Merged
merged 15 commits into from
Feb 8, 2021
Merged

Add a Strings.toHexString function #2504

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
ef67ccb
Add toHexString & minor toString improvements
Amxx Jan 29, 2021
e5109d5
changelog entry
Amxx Jan 29, 2021
d0d04a6
fix lint
Amxx Jan 29, 2021
efdc1be
replace mod with and for minor gas improvement
Amxx Jan 29, 2021
6b8292e
adding a fixed length version
Amxx Jan 29, 2021
5e277f7
changelog link to new issue number
Amxx Feb 2, 2021
3309829
Update contracts/utils/Strings.sol
Amxx Feb 4, 2021
e38178a
Update contracts/utils/Strings.sol
Amxx Feb 4, 2021
0b19e6d
Update contracts/utils/Strings.sol
Amxx Feb 4, 2021
3933ec2
Update contracts/utils/Strings.sol
Amxx Feb 4, 2021
636df47
Update contracts/utils/Strings.sol
Amxx Feb 4, 2021
86b4c19
Merge branch 'master' into feature/hexString
Amxx Feb 4, 2021
85a6667
Update contracts/utils/Strings.sol
Amxx Feb 8, 2021
eb13e9d
Merge branch 'master' into feature/hexString
Amxx Feb 8, 2021
c73fc6b
fix test
frangio Feb 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix test
  • Loading branch information
@frangio
frangio committed Feb 8, 2021
commit c73fc6b7e73b950be05d6b4292f53479ff51503e
8 changes: 5 additions & 3 deletions test/utils/Strings.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
const { constants } = require('@openzeppelin/test-helpers');
const { constants, expectRevert } = require('@openzeppelin/test-helpers');

const { expect } = require('chai');

Expand Down Expand Up @@ -45,8 +45,10 @@ contract('Strings', function (accounts) {
});

it('converts a positive number (short)', async function () {
expect(await this.strings.fromUint256HexFixed(0x4132, 1))
.to.equal('0x32');
await expectRevert(
this.strings.fromUint256HexFixed(0x4132, 1),
'Strings: hex length insufficient',
);
});

it('converts MAX_UINT256', async function () {
Expand Down