Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lodash from tests #1323

Merged

Conversation

exemplarov
Copy link
Contributor

Extracted from #1242

πŸš€ Description

  • [+] πŸ“˜ I've reviewed the OpenZeppelin Contributor Guidelines
  • [+] βœ… I've added tests where applicable to test my new functionality.
  • [+] πŸ“– I've made sure that my contracts are well-documented.
  • [+] 🎨 I've run the JS/Solidity linters and fixed any issues (npm run lint:fix).

@nventuro nventuro added kind:improvement tests Test suite and helpers. labels Sep 12, 2018
Copy link
Contributor

@nventuro nventuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great @urvalla, thanks! I'm a bit unsure regarding losing range, for larger arrays we may want to introduce our own helper.

Are these all of the instances of lodash? If so, could you also remove it from the package.json?

@nventuro nventuro requested a review from shrugs September 12, 2018 19:23
Copy link
Contributor

@shrugs shrugs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved as well, pending package.json update. thanks @urvalla!

@exemplarov
Copy link
Contributor Author

Thanks for fast reviews!

Lodash is not declared in package.json explicitly. It is a dependency of babel, eslint, etc.

The Travis build has been terminated. That's weird a little bit, as "unit tests with coverage" in the same build are fine.

@shrugs
Copy link
Contributor

shrugs commented Sep 12, 2018

Looks like mocha didn't exist because of an unresolved promise. I'm going to restart to build and see if it was a fluke, but it might be helpful to run https://github.com/mafintosh/why-is-node-running to figure out what promise isn't resolving

Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build seems to be passing now. This looks good to me. Thanks @urvalla!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Test suite and helpers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants