Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename AutoIncrementing to Counter #1307

Merged
merged 1 commit into from
Sep 13, 2018
Merged

Rename AutoIncrementing to Counter #1307

merged 1 commit into from
Sep 13, 2018

Conversation

come-maiz
Copy link
Contributor

No description provided.

shrugs
shrugs approved these changes Sep 7, 2018
View reviewed changes
Copy link
Contributor

@shrugs shrugs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nventuro nventuro merged commit b4f87bb into OpenZeppelin:master Sep 13, 2018
@frangio
Copy link
Contributor

frangio commented Sep 13, 2018

We forgot to merge this for 2.0. The rename should go in the release branch, but I'm not sure about the Index name. I understand that maybe Counter.Counter felt weird, but I don't think Index conveys the right thing.

@come-maiz come-maiz deleted the counter branch September 13, 2018 21:05
@come-maiz
Copy link
Contributor Author

I'm not completely happy with Counter.Index either, but to me it's slightly better than Counter.Counter. @nventuro @shrugs thoughts?

@frangio frangio mentioned this pull request Sep 18, 2018
Merged
frangio pushed a commit to frangio/openzeppelin-contracts that referenced this pull request Sep 18, 2018
@frangio
Rename AutoIncrementing to Counter (OpenZeppelin#1307)
658af64 
(cherry picked from commit b4f87bb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shrugs shrugs shrugs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@come-maiz @frangio @shrugs @nventuro