Remove abbreviations from parameters #1142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frangio
reviewed
Aug 1, 2018
contracts/AddressUtils.sol
Outdated
| @@ -10,10 +10,10 @@ library AddressUtils { | |||
| * Returns whether the target address is a contract | |||
| * @dev This function will return false if invoked during the constructor of a contract, | |||
| * as the code is not actually created until after the constructor finishes. | |||
| * @param _addr address to check | |||
| * @param _address address to check | |||
There was a problem hiding this comment.
This one should also be _account IMO. Contracts are accounts too. Just not externally owned accounts.
…in-solidity into refactor/abbreviations
nventuro
reviewed
Aug 2, 2018
contracts/access/rbac/Roles.sol
Outdated
| } | ||
|
|
||
| /** | ||
| * @dev remove an address' access to this role | ||
| * @dev remove an account' access to this role |
frangio
approved these changes
Aug 2, 2018
This was referenced Apr 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Description
Avoid abbreviating things.
This PR renames _sig to _signature and _addr to _account
Requires #1141
npm run lint:all:fix).