Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linter: upgrade to v1 #555

Closed
duaraghav8 opened this issue Nov 12, 2017 · 1 comment
Closed

Linter: upgrade to v1 #555

duaraghav8 opened this issue Nov 12, 2017 · 1 comment
Assignees

Comments

@duaraghav8
Copy link

duaraghav8 commented Nov 12, 2017

Hi @maraoz ,
Its been quite a while since Solium v1 was released. It comes with significant improvements including automatic code fixing, new security checks for contract code and ability to configure rule behavior (like 2 spaces instead of 4).

I'm raising this issue to simply make you aware, since v1 will significantly improve your workflow.

Adoption is pretty simple:

npm i -g solium

Going by your current .soliumrc.json, your new .soliumrc.json would look like:

{
  "extends": "solium:all",
  "plugins": ["security"],
  "rules": {
    "mixedcase": "off"
  }
}

(Although I should inform you that the mixedcase rule's bugs have been resolved)

If, for eg, you'd like to disable a security rule you don't agree with, simply add "security/rule-name": "off" inside rules object.

Run normally using solium -d contracts/ or solium -d contracts/ --fix to apply code fixes (wherever possible).

Usage docs
List of Security Rules

Please do not hesitate in closing this issue if you feel its not currently a priority. However, I do recommend that you upgrade to further improve contract security. Feel free to ask me anything!

(I can make a PR for this, but a dev must update their solium version on workstation too)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants