Consider simpler initializer modifier

[frangio]

The current version of the initializer modifier includes some logic for backwards compatibility that was added in #3450, which was in fact a simplification of the backwards compatibility code introduced in #3344.

We should consider further simplifications that break backwards compatibility for 5.0.

Haven't thought about this yet but it would probably come down to making initializer exactly equivalent to reinitializer(1). This means that instead of:

openzeppelin-contracts/contracts/proxy/utils/Initializable.sol

Lines 85 to 88 in d59306b

	require(
	(isTopLevelCall && _initialized < 1) || (!Address.isContract(address(this)) && _initialized == 1),
	"Initializable: contract is already initialized"
	);

the code should look more like:

openzeppelin-contracts/contracts/proxy/utils/Initializable.sol

Line 119 in d59306b

require(!_initializing && _initialized < version, "Initializable: contract is already initialized");

[frangio]

Note: In #3344 it is explained that the isConstructor exception was added back (after removal in 4.0) in order to use the initializer modifier to disable the initialization of implementation contracts with the following pattern:

contract A is Initializable {
    constructor() initializer { /* ... */ }
}

contract B is A {
    constructor() initializer { /* ... */ }
}

This is no longer a requirement since the introduction of _disableInitializers.

[balajipachai]

@frangio is this open for a PR or just a suggestion citing Consider?

[frangio]

Consider means undecided.

[balajipachai]

Okay 👍