Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replacing deprecated expectEvent.inLogs in test files #3332

Closed
niccolopetti opened this issue Apr 10, 2022 · 0 comments · Fixed by #3333
Closed

Replacing deprecated expectEvent.inLogs in test files #3332

niccolopetti opened this issue Apr 10, 2022 · 0 comments · Fixed by #3333

Comments

@niccolopetti
Copy link
Contributor

🧐 Motivation
openzeppelin-test-helpers deprecated expectEvent.inLogs in favor of expectEvent, which receives the full receipt object (not just the logs), and supports both web3 and truffle contract receipts (changelog here )

📝 Details
I think code should be updated accordingly, replacing all the occurrences of the deprecated version
@niccolopetti niccolopetti changed the title Replacing deprecated expectEvent.logs in test files Replacing deprecated expectEvent.inLogs in test files Apr 10, 2022
niccolopetti added a commit to niccolopetti/openzeppelin-contracts that referenced this issue Apr 10, 2022
@niccolopetti
Fix deprecated expectEvent.inLogs OpenZeppelin#3332
58383d9
@niccolopetti niccolopetti mentioned this issue Apr 10, 2022
Merged
1 task
frangio pushed a commit that referenced this issue Apr 23, 2022
@niccolopetti
Fix deprecated expectEvent.inLogs #3332 (#3333)
d4e6236
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix deprecated expectEvent.inLogs #3332 niccolopetti/openzeppelin-contracts
1 participant
@niccolopetti